add gosec linter, various small fixes#739
Merged
tzdybal merged 4 commits intoevstack:mainfrom Feb 24, 2023
Merged
Conversation
tzdybal
requested review from
a team,
Manav-Aggarwal and
tuxcanfly
and removed request for
a team
gupadhyaya
reviewed
Feb 22, 2023
gupadhyaya
reviewed
Feb 22, 2023
gupadhyaya
reviewed
Feb 22, 2023
Contributor
gupadhyaya
left a comment
gupadhyaya
left a comment
There was a problem hiding this comment.
I would leave the math/rand as is, since crpto/rand is atleast an order magnitude expensive.
tzdybal
approved these changes
Feb 23, 2023
Manav-Aggarwal
approved these changes
Feb 24, 2023
Codecov ReportBase: 54.97% // Head: 54.81% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 54.97% 54.81% -0.17%
==========================================
Files 52 52
Lines 9824 9823 -1
==========================================
- Hits 5401 5384 -17
- Misses 3630 3642 +12
- Partials 793 797 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes, added the gosec linter since it caught a few issues. I ignored all the
math/randusages, but I'm happy to switch them tocrypto/randif you'd like to not have thenolints.